Bug #7307
closed
arv-git-httpd tests trigger go1.3.3 warnings
Description
go 1.3.3 prints warnings when running arv-git-httpd tests:
1. from net/http regarding the value "bogus" not being a valid RemoteAddr entry (it needs to be in "host:port" format)
2. from net/http/cgi because the mocked up cgi script does not return valid http headers (they are missing the required carriage return characters before the new line)
Updated by Joshua Randall over 10 years ago
Actually, for (2) it isn't just the missing CR's, but also the mocked up CGI script is returning the "HTTP/1.1 ..." line, which isn't a CGI script's job.
Updated by Joshua Randall over 10 years ago
********** Running services/arv-git-httpd tests **********
2015/09/11 08:41:45 Internal error: SplitHostPort(r.RemoteAddr=="bogus"): missing port in address bogus
2015/09/11 08:41:45 cgi: bogus header line: HTTP/1.1 200 OK
Updated by Joshua Randall over 10 years ago
So, I now see that the first line "Internal error: SplitHostPort..." is intentional, as it is that error handling that is being tested at the time. The fix for this should be to print a message before the error that says to ignore the forthcoming error.
Updated by Joshua Randall over 10 years ago
Updated by Brett Smith over 10 years ago
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
Applied in changeset arvados|commit:d0f91b34eedec9af266ec4877a3005dd627ad38e.