Project

General

Profile

Actions

Bug #7310

closed

arv-git-httpd tests fail with git 2.x

Added by Joshua Randall over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Target version:
-
Story points:
-

Description

I'm getting a few test errors with arv-git-httpd that seem to be down to the way it tests for failing responses from the server.

It seems that the test has a regex that will only match versions of git prior to 1.8 or so (since https://github.com/git/git/commit/6d052d78d74e581dd93dd6328d3c214f469e34d7)

An example error is:

2015/09/11 13:50:43 server_test: TestExpiredToken()
2015/09/11 13:50:43 integration_test: RunGit: executing command [git fetch http://[::]:49878/active/foo.git]
2015/09/11 13:50:43 "[::1]:39058" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 13:50:43 "[::1]:39060" "" 401 "no credentials provided" "" "GET" "/active/foo.git/info/refs" 
2015/09/11 13:50:43 "[::1]:39060" "<invalid>" 500 "arvados API server error: Not logged in (401: 401 Unauthorized) returned by 0.0.0.0:38109" "active/foo" "GET" "/active/foo.git/info/refs" 

----------------------------------------------------------------------
FAIL: /tmp/tmp.nGTnqSsiz4/src/git.curoverse.com/arvados.git/services/arv-git-httpd/server_test.go:73: GitSuite.TestExpiredToken

git [fetch http://[::]:49878/active/foo.git] => exit status 128
remote: arvados API server error: Not logged in (401: 401 Unauthorized) returned by 0.0.0.0:38109
fatal: unable to access 'http://[::]:49878/active/foo.git/': The requested URL returned error: 500

/tmp/tmp.nGTnqSsiz4/src/git.curoverse.com/arvados.git/services/arv-git-httpd/server_test.go:77:
    c.Assert(err, check.ErrorMatches, `.* 500 while accessing.*`)
... error string = "remote: arvados API server error: Not logged in (401: 401 Unauthorized) returned by 0.0.0.0:38109 // fatal: unable to access 'http://[::]:49878/active/foo.git/': The requested URL returned error: 500 // " 
... regex string = ".* 500 while accessing.*" 
Actions #1

Updated by Joshua Randall over 10 years ago

  • Assigned To set to Joshua Randall
  • % Done changed from 0 to 30
Actions #2

Updated by Joshua Randall over 10 years ago

  • % Done changed from 30 to 90
Actions #3

Updated by Tom Clegg over 10 years ago

  • Status changed from New to Resolved
  • % Done changed from 90 to 100

Applied in changeset arvados|commit:d805ea58fa7f4fce9e457df7073b1b414249d2ed.

Actions

Also available in: Atom PDF