Story #10524
closed
[Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.
Added by Radhika Chippada over 8 years ago.
Updated over 8 years ago.
Assigned To:
Radhika Chippada
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
- Subject changed from [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment. Refers to #10310 to [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.
- Description updated (diff)
- Assigned To set to Radhika Chippada
- Target version set to 2016-11-23 sprint
- Status changed from New to In Progress
- I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment". The
no_jobs_api
var isn't used anywhere else in the templates, so it can be avoided.
- Do you think writing some tests to check those alternating labels would be useful? Maybe mocking
PipelineInstance.api_exist?
would allow an easy way of testing the changes.
Jenkins tests seem to have had some kind of problem. I ran apps/workbench
tests locally without failures.
I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment".
Updated
Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.
Updated controller disabled api test
Thanks.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:6f461f4d0a996da85140982846a5d5c10ccfaae4.
- Related to Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active added
- Related to deleted (Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active)
Also available in: Atom
PDF