Bug #10534
closed
build broken due to daemon.SdNotify signature change
Description
I get an error doing an `arvbox restart dev` from scratch:
2016-11-15_15:24:05.24906 src/git.curoverse.com/arvados.git/services/arv-git-httpd/main.go:70: not enough arguments in call to daemon.SdNotify
It looks like the function signature of daemon.SdNotify was changed 6 days ago upstream to take a second argument:
https://github.com/coreos/go-systemd/commit/0c088eaedf4396216a47ca971d4630f1697186bf
Updated by Joshua Randall over 9 years ago
- Subject changed from arv-git-httpd broken (at least in arvbox) to build broken due to daemon.SdNotify signature change
N.B. it seems other components also call SdNotify and suffer from the same issue - arv-git-httpd was just the one I noticed first.
Updated by Joshua Randall over 9 years ago
broken components:
services/arv-git-httpd
services/keep-web
services/keepproxy
services/keepstore
services/crunch-dispatch-slurm
Updated by Tom Morris over 9 years ago
- Status changed from New to Resolved
Fixed by commit 38fae0458644b89322ddeac125971800b9e452e5
p.s. Although the original breaking commit was made 6 days ago, it wasn't merged into master and released as v14 until yesterday
https://github.com/coreos/go-systemd/commit/dd023778d626202550d92fee51b5067c5eb8a876
https://github.com/coreos/go-systemd/releases/tag/v14