Arvados

Branch 10903-api-cancel-cascade @ 3f833687 addresses the API server updates: (1) enhance job.cancel method to support cascade parameter, (2) add cancel method with cascade to pipeline_instance.

Tests @ https://ci.curoverse.com/job/developer-run-tests/157

Tom: branch 10903-wb-cancel-cascade @ 210af1cc7ede88914026fde078e45ef84c187a0c has both API and workbench updates. Please review this branch if you prefer to review both together.

One question: Let's say I have a job with job and pipeline components and I cancel it in workbench. Now I see that the main job and the child job are "cancelled", but the pipeline status is shown as "paused". If I were to navigate to that child pipeline, I would be able to click on it's resume button. Just wondering if this might be confusing from UI perspective.

API and workbench tests passed @ https://ci.curoverse.com/job/developer-run-tests/161/

Thanks.

10903-api-cancel-cascade @ 3f83368

I think this needs to be protected by a transaction. Suggest new signature for cancel method:

def cancel(cascade: false, need_transaction: true)
  if need_transaction
    ActiveRecord::Base.transaction do
      cancel(cascade: cascade, need_transaction: false)
    end
    return
  end
  # ...

(ruby2 has native named params, so we should be using those instead of positional params...)

Can do more filtering in the database in these sections:

-    Job.where(uuid: children).each do |job|
-      job.cancel cascade if job.state.in?([Queued, Running])
+    Job.where(uuid: children, state: [Queued, Running]).each do |job|
+      job.cancel(cascade: cascade, need_transaction: false)
     end

Branch 10903-wb-cancel-cascade at 2e9cb97 addresses the suggestions from note 9 (need_transaction added).

Tests @ https://ci.curoverse.com/job/developer-run-tests/165/

LGTM!