Arvados

• fix an unclosed "rows" object
• add authenticated /_health/ping and /_health/db handlers
• add # open db connections to /debug.json

The health-check specs here (authentication, URLs, responses) are the ones Nico and I developed last week based on existing conventions and ease of integration with consul, nagios, etc. I've since written them up on #11906.

• Should "/_health/ping" and "/_health/db" also check if the ManagementToken is configured and bearer token matches? (I could not tell if this was already the case ...)

• Would it make sense to test when management token is not configured as well (disabled)?

      if rtr.Config.ManagementToken == "" {
            http.Error(w, "disabled", http.StatusNotFound)
      }

Radhika Chippada wrote:

• Should "/_health/ping" and "/_health/db" also check if the ManagementToken is configured and bearer token matches? (I could not tell if this was already the case ...)

Yes, mgmtAuth() covers the http.ServeMux handling /_health/ so the individual handlers don't need to re-check.

• Would it make sense to test when management token is not configured as well (disabled)?

Yes, added this test.

11901-ws-db-conns @ 5c860fdbf28128e7d11a9dff8b5c30777c2cbfeb