Bug #12316
closed
- Subject changed from [Workbench] deletion of data collections destroying the provenance graph - rendering crashes
to [Workbench] deletion of data collections destroying the provenance graph - rendering crashes
- Description updated (diff)
- Assigned To set to Ward Vandewege
- Target version set to 2017-09-27 Sprint
- Status changed from New to In Progress
This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.
- Status changed from In Progress to Resolved
Lucas Di Pentima wrote:
This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.
Done in 3895b3adf05dc6c8d7b66e6bdd42e576a03b1f09.
I've merged this, thanks!
Thanks for the quick fix! 6 hours from report to fix and <12 hours to merge. Don't forget to prepare to demo at sprint review :-)
Point of clarification for those following along in the distant future -- PDHs never cease to exist. They might not be resolvable to a collection (or they might resolve to multiple collections), but they always exist (says pedantic Tom).
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Tom Morris