Feature #14201
closed
[API] Accept "exclude_home_project" flag in groups#contents
Added by Tom Clegg over 6 years ago.
Updated about 6 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
If a truthy
exclude_home_project query parameter is given,
- include only items that are not otherwise reachable by the current user via project tree -- i.e., items whose parents are not visible to the current user, or are users other than the current user, or are non-project groups (see #13146)
- return a "bad request" error if parent/owner uuid is also given
- Description updated (diff)
- Related to Story #13146: [API] Endpoint to get projects shared with me added
- Target version set to To Be Groomed
- Story points set to 1.0
- Description updated (diff)
- Description updated (diff)
- Target version changed from To Be Groomed to 2018-10-03 Sprint
- Assigned To set to Lucas Di Pentima
- Subject changed from [API] Accept "shared with me" flag in groups#contents to [API] Accept "exclude_home_project" flag in groups#contents
- Description updated (diff)
- Status changed from New to In Progress
- Assigned To changed from Lucas Di Pentima to Peter Amstutz
A couple of comments:
- On file
services/api/app/controllers/arvados/v1/groups_controller.rb, lines 115, 266: In case owners var contain lots of repeated uuids, would it be convenient to get the de-duplicated version before passing it to que query? (I’m not sure if Active Record already does this)
- Should
exclude_home() be a protected method?
- Fuse tests seem to have halted on
test_safer_realpath, don't know if it's related to this update.
Lucas Di Pentima wrote:
A couple of comments:
- On file
services/api/app/controllers/arvados/v1/groups_controller.rb, lines 115, 266: In case owners var contain lots of repeated uuids, would it be convenient to get the de-duplicated version before passing it to que query? (I’m not sure if Active Record already does this)
Now converts to Set() (which will deduplicate entries) and then back to Array.
- Should
exclude_home() be a protected method?
Fixed.
- Fuse tests seem to have halted on
test_safer_realpath, don't know if it's related to this update.
Seems unlikely but anything is possible, let's see what happens on the next run.
14201-exclude-home-project @ 8cfec0701cd01994502b53dbaf73cd86a24ff72e
https://ci.curoverse.com/view/Developer/job/developer-run-tests/911/
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by Tom Morris 
Updated by 
Updated by