Arvados

• Update WB2 to use the new vocabulary format.
• Text search for properties is available via the search bar at the top. Label search is available in the advanced search view, which populates the search bar automatically.
• When a user starts typing in the advanced search label entries, present an autocomplete list. Display preferred label first.
• When adding a label to a resource, use the same autocomplete view as the advanced search.

Updates at commit:366d290 - branch 15069-tag-searching-by-ids (WB2 repo)

The advanced search dialog now autocompletes properties' keys/values using the new vocabulary, and creates the correct search query string. Also does the right thing when arriving from a bookmarked search link, it correctly renders the property "chips" when the advanced search dialog is opened.

Questions for the reviewer¶

• I’m not sure why I had use <any> on 'const connectVocabularyAndPropertyKey = compose<any>(…)' at src/views-components/resource-properties-form/property-value-field.tsx to be able to pass my own prop to the component. This surely isn’t the best solution. Maybe related to this? https://github.com/DefinitelyTyped/DefinitelyTyped/issues/16990#issuecomment-472885681 (I'm not yet completely used to work with generics)
• The advanced search UI has a preexisting minor bug: when the user adds properties criteria on the search, it keeps adding those properties even if the user enter the same property key twice. The search query string is correctly constructed, though. Should this bug be a blocker for this story? I've been trying to fix it but it doesn't seem trivial for now.

How to test¶

Just pointing the branch to 4xphq should work, as it would load the new vocabulary example from the branch itself.

I've realized that I was committing with my personal email address. Deleted the branch and re-pushed a corrected one at commit:c33dec5 (wb2 repo)

Updates at commit:2a700288 (wb2 repo)

• Fixes the preexisting bug mentioned on note-17

(deleted comment, not relevant to this branch)

I don't know if this is in scope, but if I just put "dog" into the search, it doesn't find anything. However, I can search for "IDVALANIMALS2" and that works. It would be nice if the search recognized "dog" and performed an additional search for "IDVALANIMALS2". Perhaps this is blocked on #15070 ?

Related, this seems to assume that all properties have migrated to identifiers, because if you search for "Animal: Dog" then the actual search is has:"IDTAGANIMALS":"IDVALANIMALS2", and you cannot easily search for something that has properties with the literal text "Animal: Dog".

Also, the search history stores (and displays) 'has:"IDTAGANIMALS":"IDVALANIMALS2"' which is not very meaningful to a human going back and choosing a past search.

It's also possible to have {"IDTAGANIMALS":"IDVALANIMALS2", "Animal: Dog"} for properties on a collection, they will appear the same in the property chips on the collection page.