Story #15181
closed
[cwl] Remove support for jobs api in a-c-r
Added by Peter Amstutz about 5 years ago.
Updated over 4 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
Remove jobs API support in a-c-r and use containers API by default. The --api argument should remain valid but only accept 'containers'.
delete jobs api tests.
migrate the unit test test_overall_resource_singlecontainer to test_container.
- Description updated (diff)
- Description updated (diff)
- Description updated (diff)
- Target version changed from To Be Groomed to Arvados Future Sprints
- Story points set to 1.0
- Related to deleted (Story #15133: Remove crunch v1 (jobs api))
- Target version changed from Arvados Future Sprints to 2019-08-14 Sprint
- Assigned To set to Peter Amstutz
Some minor comments:
- Some documentation might need updating, for example: https://doc.arvados.org/user/cwl/cwl-run-options.html (and maybe the upgrade notes?)
- File
executor.py:L400 — There’re a number of error messages mentioning "—api=jobs" that I think they’re no longer valid
- File
__init__.py
- Lines 99 & 102 also mentions the job api in argument help messages.
- Lines 157, 160 & 188 make the clarification that some argument are “containers api only”, this is no longer needed IMO
- Line 300’s code comment references
ArvadosJob.done()
Providing that the tests pass, this LGTM. Thanks!
- Status changed from New to Resolved
Also available in: Atom
PDF
Updated by 
Updated by Tom Morris 
Updated by