Arvados

The provenance/used_by methods haven't been updated for containers, meaning they don't return particularly useful results. We should either postpone or expand the scope of this story to include updating adding traversal of containers in the provenance graph.

15422-collections-prov-doc @ b26a7ca6d495377344fc425e0c8e93275abef575

• Update provenance and used_by feature on API server to traverse containers/container requests
• Update workbench rendering
  • handle containers/container requests
  • use left-right layout for collections (works better visually when there are large fanouts)
  • rework container request rendering so it isn't so much of a special case
  • don't render extra items that are not part of the provenance graph.

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1391/

• Looks like the test run has actual broken workbench tests.
• In the documentation, can we be more specific about what the attributes belong to? i.e. instead of (via "output_uuid" or “log_uuid”) maybe (via the “output_uuid” or “log_uuid" attributes of the container request)? It also would be more clear if the attributes were highlighted.
• Shouldn't the following line be outside the if like it is for ContainerRequests above: source:services/api/app/controllers/arvados/v1/collections_controller.rb@b26a7ca6d495377344fc425e0c8e93275abef575#L246

Eric Biagiotti wrote:

• Looks like the test run has actual broken workbench tests.

Fixed. Thanks for pointing that out.

• In the documentation, can we be more specific about what the attributes belong to? i.e. instead of (via "output_uuid" or “log_uuid”) maybe (via the “output_uuid” or “log_uuid" attributes of the container request)? It also would be more clear if the attributes were highlighted.

Done.

• Shouldn't the following line be outside the if like it is for ContainerRequests above: source:services/api/app/controllers/arvados/v1/collections_controller.rb@b26a7ca6d495377344fc425e0c8e93275abef575#L246

No. That's because when searching "up" (provenance) it searches by uuid but when it is searching "down" (used by) it searches by portable data hash. If that line was outside the if statement, the collection would be added twice, once by uuid and again by pdh.

15422-collections-prov-doc @ 508f13840841afc5938f7210a999ff58f002b29d

https://ci.curoverse.com/view/Developer/job/developer-run-tests/1399/

Thanks, all the tests pass now. This LGTM!