Story #15922
closed
Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)
Added by Tom Clegg about 5 years ago.
Updated about 5 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
- Related to Story #14287: [Controller] Refactor API code / routing added
- Subject changed from Change EnableBetaController14287 (default false) to ForceRailsAPI (default false) to Change EnableBetaController14287 (default false) to ForceLegacyAPI14 (default false)
- Status changed from New to In Progress
- Assigned To set to Tom Clegg
Just a couple of comments, otherwise LGTM:
- Should the controller log a warning when the flag is true reminding the admin that will be deprecated?
- Do you think adding a test for existence of
writable_by on responses would be useful? Asking because etag got one but I believe the other didn’t.
I'm reluctant to warn about something the admin had to do explicitly after (presumably) reading the caveats in the config file comment. The config loader will warn automatically ("unknown config key") if it's still in the config when the flag is removed/unsupported.
Yes to a writable_by test. Added to 15922-force-legacy-api-14 @ 1c4a2d386dc0d2a85c86171801c6681d76fb12fe
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by