Arvados

When indexing, it looks like we're already skipping dirs that don't conform to keepstore's storage layout: source:services/keepstore/unix_volume.go#L355

var blockDirRe = regexp.MustCompile(`^[0-9a-f]+$`)
var blockFileRe = regexp.MustCompile(`^[0-9a-f]{32}$`)
...
                if !blockDirRe.MatchString(names[0]) {
                        continue
                }
                ...
                blockdir, err := v.os.Open(blockdirpath)

However, the "empty trash" goroutine does walk the entire tree.

        err := filepath.Walk(v.Root, func(path string, info os.FileInfo, err error) error {
                if err != nil {
                        v.logger.WithError(err).Errorf("EmptyTrash: filepath.Walk(%q) failed", path)
                        return nil
                }
                todo <- dirent{path, info}
                return nil
        })

That walk func should check dirnames and return filepath.SkipDir when appropriate.

16425-skip-unused-dirs @ b257b5e4fca36172a79db2fd2cf8ab843cf50d1c -- developer-run-tests: #1915

Tom Clegg wrote:

16425-skip-unused-dirs @ b257b5e4fca36172a79db2fd2cf8ab843cf50d1c -- developer-run-tests: #1915

LGTM, thanks!