Arvados

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/3efbabfcd06a10b83f1f130141d6c1f6017037cf
Test run: developer-tests-workbench2: #401
Branch: 16647-Responsible-person

Added the responsible person renderer

Some comments:

• General UI enhancement suggestion: In the current state of affairs, when an uuid has to be rendered with the user's name for example, the first and last names are displayed and their uuid added between parenthesis. The issue I'm seeing (and I think failed to see when first implemented) is that if the user's profile doesn't have any name assigned, only the uuid between parenthesis will be shown. We could just show the uuid without the parenthesis in this case.
• I'm scanning the updates and not seeing any mention of original_owner or even responsible_person_uuid, and AFAICT the code is displaying the collection's owner uuids as the responsible person, is my understanding correct? This ticket is about displaying the value of the managed property usually (but not always) named responsible_person_uuid as a first and last name. I believe I already sent this, but just in case I didn't, please check this doc page: https://doc.arvados.org/v2.1/admin/collection-managed-properties.html -- you will see that the managed property key could be anything, so I think the correct strategy would be to check the cluster's exported config Collections.ManagedProperties keys and check for anything with Function: original_owner on it, and check which key the current configuration is using.
• I like your idea of showing the responsible person's name & uuid on the main collection panel along with other data. Not just from the UI point of view but also because doing so on the properties panel could be cumbersome to implement as there's already logic in place to show vocabulary terms. The thing I would correct in this approach is to check if a collection does have the property and only then add the Responsible person row on that panel. Some clusters won't have the feature enabled so it doesn't make sense to add that anyways.
• I've added the proper cluster config for the cypress tests so you can add some there. It would be interesting to have a collection owned by user A, copied by user B (you can do the copying through API calls to avoid adding test time on that operation) and then check that WB2 correctly show the different uuids & names (owner versus responsible person). I think this config change made a preexisting cypress test fail because it's assuming no property is auto-added - developer-tests-workbench2: #404
• Right now Cypress tests on Jenkins are failing if you leave master as the arvados_git_hash parameter, you can use b1a2bad as a hash parameter as a workaround until we fix that.

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/72470537b4b0a8470b6f5360817cc4039d74978c
Test run: developer-tests-workbench2: #418
Branch: 16647-Responsible-person

Added the responsible person renderer

• File src/common/config.ts: I think Collections.ManagedProperties should be declared as a dictionary of keys being strings with values being dicts with Function or Value members with string values and optional Protected members with boolean values. At least that's how the current docs describe the feature. (https://doc.arvados.org/v2.1/admin/collection-managed-properties.html)
• There's one cypress test failing because of the config change I made on commit c54ac3e -- you will be able to fix the test by instead of doing a complete comparison of properties, just assert that the one being tested exists no matter what else is set as property.
• As we talked on chat, the feature shouldn't be hardcoded to display resposible_person_uuid because the cluster could be configured differently
• On the previous version, the responsible person field was also displayed on the main info panel, but now it seems that it got removed, why is that?
• My arvbox instance user doesn't have a first and last name set, so the "Responsible person" field on the details panel now appears as "()" -- empty parenthesis. I think it should just show the UUID if the user's first and last names aren't available.
• Please make tests of all these observations before the next review pass to make the process more dynamic.

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/25dc48d4655faf7a6eebdb717e225b77d8ff5c3f
Test run: developer-tests-workbench2: #419
Branch: 16647-Responsible-person

Added config key search and tests

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/bae0bd90f56fa3c7293c0dc9cba0cf0cb820649b
Test run: developer-tests-workbench2: #420
Branch: 16647-Responsible-person

Style fix

This LGTM, thanks!