Story #16680
closed
Ensure expired tokens are handle properly
Added by Peter Amstutz over 4 years ago.
Updated over 4 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
If the user attempts to use an expired token, Workbench 2 should detect that the token is expired, notify the user that they have been logged out, and send them back to the log in page.
- Tracker changed from Bug to Story
- Description updated (diff)
- Target version set to 2020-09-09 Sprint
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
Updates at arvados-workbench2|202a49e - branch 16680-expired-token-handling
Test run: developer-tests-workbench2: #82 
- Enhanced
commonService's error reporting in order to get the status code on the error handler.
- Logs out user when receiving a 401 error with message "Not logged in"
- Changed the way "Not found" dialog is shown: instead of parsing the error message, it's displayed whenever a 404 error is received.
I'm not sure how to unit test this. I think I could make an e2e test by setting the token to something invalid and checking that the login form is shown.
Lucas Di Pentima wrote:
Updates at arvados-workbench2|202a49e - branch 16680-expired-token-handling
Test run: developer-tests-workbench2: #82
- Enhanced
commonService's error reporting in order to get the status code on the error handler.
- Logs out user when receiving a 401 error with message "Not logged in"
- Changed the way "Not found" dialog is shown: instead of parsing the error message, it's displayed whenever a 404 error is received.
Tested manually, worked as expected. I noticed that if you try to download something, keep-web doesn't return good errors to the browser, but I made that a separate ticket #16774.
I'm not sure how to unit test this. I think I could make an e2e test by setting the token to something invalid and checking that the login form is shown.
I think that's a good idea. Otherwise LGTM.
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Anonymous