Arvados

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/f0fb75714e54f5191a7026eedbec757ee22a682c
Test run: developer-tests-workbench2: #76

Added copy of full token, made tests more realistic

Reviewing arvados-workbench2|f0fb757 - branch 16735-Require-password-login

• Great idea to test the function!
• Instead of adding more checks, one for every Login type, how about having an array of login type names and iterate over it to check if at least one of those exist and has an "Enabled: true” member instead of requiring that all login type to exist on all the clusters that wb2 has a session? This alternative approach would make easier to add more login types (for example, Tom is adding a “Test” login type atm) and also allow wb2 to talk with older cluster versions at the same time.

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/a2a35bb1683304edd8d20e1a2b5df29e81669b46
Test run: developer-tests-workbench2: #77

Added array with possible login options

Great, thanks! How about adjusting the tests so that validates the new behaviour?
Having a list of Login types and confirming that the func returns true if any of those is enabled. That way we could easily expand the test cases when new login types are added.
We could also check that having a login type not listed doesn't make the func return true.

New version: https://dev.arvados.org/projects/arvados/repository/arvados-workbench2/revisions/86df4771fd4ce9e88bd349f738d5833d5cd70c51
Test run: developer-tests-workbench2: #78

Added array with possible login options

LGTM, thanks!