Bug #16735
closed
Require password login check throws error that variable is undefined
Added by Daniel Kutyła over 4 years ago.
Updated about 4 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
requirePasswordLogin function need better null|undefined checks in order to aviod null pointer errors
- Status changed from New to In Progress
Reviewing arvados-workbench2|f0fb757 - branch 16735-Require-password-login
- Great idea to test the function!
- Instead of adding more checks, one for every Login type, how about having an array of login type names and iterate over it to check if at least one of those exist and has an "Enabled: true” member instead of requiring that all login type to exist on all the clusters that wb2 has a session? This alternative approach would make easier to add more login types (for example, Tom is adding a “Test” login type atm) and also allow wb2 to talk with older cluster versions at the same time.
Great, thanks! How about adjusting the tests so that validates the new behaviour?
Having a list of Login types and confirming that the func returns true if any of those is enabled. That way we could easily expand the test cases when new login types are added.
We could also check that having a login type not listed doesn't make the func return true.
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by