Arvados

16941-inactive-remotes @ arvados-workbench2|0ca7039728489e25ae1e196278454e7bafbca948

developer-tests-workbench2: #116

16941-inactive-remotes @ arvados-workbench2|d924f14c5a81265fbd0f550ccf498fe791fc5b54

• Fix tests. Had to add in the ability to mock fetching the cluster config. This might be useful in other places.

developer-tests-workbench2: #118

Integration tests failed because of some missing import problem, but I think there's also some other problem on src/store/auth/auth-action-session.ts.
It's very odd that the compiler haven't noticed this, have we disabled some type checking feature recently without noticing?

Lucas Di Pentima wrote:

Integration tests failed because of some missing import problem, but I think there's also some other problem on src/store/auth/auth-action-session.ts.
It's very odd that the compiler haven't noticed this, have we disabled some type checking feature recently without noticing?

Yes, that's weird. I was running the unit tests but not the integration tests. Iit is still strange that it wasn't giving typescript compile failures. Fixed.

16941-inactive-remotes @ commit:fb3f4deaceade35ad36718ce814d6ff4d0cb996b

developer-tests-workbench2: #119

Note: as noted in standup, in my local test I was getting an unrelated test failure that seems to be due to a project table list refreshing (and changing sort order) while the context menu was open, resulting in a different item being selected. I don't know if it will happen again on Jenkins.

=> https://dev.arvados.org/issues/16951

Just one observation:

• At src/views/search-results-panel/search-results-panel-view.tsx line 117 there’s a debugging console.log() statement.

Other than that, it LGTM.