Arvados

Updates at 9df0dc3888f9d63ae0844e7425cd02b21af9da68 - branch 17526-3rd-party-access-ui
Tests: developer-tests-workbench2: #450

• Rename webdav dialong to Access with 3rd party client
• Rename cyberduck tab to webdav, mention credentials in mac/win tab
• Add wget/curl tab to webdav dialog

Some comments:

• As the context menu items are ordered by label, I think it would be better to name it "Open with 3rd party client" to keep it on the same place and avoid user confusion.
• The "wget / curl" tab:
  • The supportsWebdav boolean I guess it should be renamed to something like isCollection because that's what the 4zz18 prefix means (https://doc.arvados.org/v2.2/api/methods/collections.html)
  • It already provides the username/password on the wget command (good idea!), so I think it isn't necessary to specify them separately.
  • The "Copy to clipboard" button just copies the collection's URL, I think it would be better to copy the entire command so that the user can easily paste it on the shell.
  • How about adding a curl command too for completeness' sake?
  • Also, I think it would be nice to format those commands using monospaced fonts as we do on the "Get API Token" user menu dialog, wdyt?

All good suggestions - a note about curl since it seems it doesn't support parsing the html and downloading the whole folder, I added a <FILENAME> at the end of the curl url. Do you think that's ok and/or should I add a note? I don't see this dialog option on files so I think the url should be a folder in every case unless I'm missing a path to make the dialog come up for a specific file.

Updates at 41a579060898b29e6d50000e6f95c93d97a7a433
Tests developer-tests-workbench2: #451

• Change webdav dialog title to "Open" to preserve ordering
• Rename supportsWebdav to isCollection
• Fix webdav dialog > wget tab command copy button only copying url
• Use codesnippet component on webdav dialog wget command for monospace
• Remove redundant user/pass from webdav wget tab and add curl command

Some small comments:

• You're right, I forgot that curl doesn't do mirroring, I think it would be nice to have a brief note by the "Curl command" label to clarify that's meant for downloading individual files, because the <FILENAME> tag isn't visible at first unless the user scrolls to all the way to the right.
• One additional nit: In the WEBDAV tab, I think it's more correct to mention GNOME (all caps) instead of Gnome. GNOME is an acronym IIRC.

The rest looks good to merge, thanks!