Bug #18590
closed[api] invalid value in discovery doc
Description
In `app/controllers/arvados/v1/groups_controller.rb` we say
def self._contents_requires_parameters
params = _index_requires_parameters.
merge({
uuid: {
type: 'string', required: false, default: nil,
},
...
That `default: nil` ends up in our discovery doc as
"uuid": {
"type": "string",
"required": false,
"default": null,
"description": "",
"location": "query"
},
That is the only place in our discovery doc where we say `"default": null`, and that does not conform with the spec. The value for `"default"` must be a string, as per https://developers.google.com/discovery/v1/reference/apis.
Updated by Ward Vandewege over 4 years ago
- Status changed from New to In Progress
Updated by Ward Vandewege over 4 years ago
Ready for review at 49ef11e68168170d3ba4bebf17a428d99759178f on branch 18590-fix-discovery-doc.
Tests passed at developer-run-tests: #2844
Updated by Tom Clegg over 4 years ago
49ef11e68168170d3ba4bebf17a428d99759178f LGTM, thanks.
The GroupContentsOptions struct used by controller has UUID string `json:"uuid,omitempty"` and I guess this RailsAPI change confirms the ",omitempty" isn't needed there. Mostly harmless though.
Updated by Ward Vandewege over 4 years ago
- % Done changed from 0 to 100
- Status changed from In Progress to Resolved
Applied in changeset arvados-private:commit:arvados|e67d7d52092ba61e272a597e2fa9d98aee65c004.