Arvados

19466-cwl-io @ 210f068ee8ba5b6f56459ba2f14c86b59385b29b

Example here: https://workbench2.ce8i5.arvadosapi.com/processes/ce8i5-xvhdp-jx0dihjon1kflll

I'm pretty sure I need to update tests before this is ready for review, but the actual feature is quite simple.

19466-cwl-io @ a7caca5452e7ece2ea3f6efd3ab4bb992c1f31fb

• record cwl_input and cwl_output in container request properties for workflow steps
• does not record it on the top level workflow because that information is already available a different way and I'd prefer to avoid duplicating it

developer-run-tests: #3311

Just a couple of questions:

• All test fixes are related to properties['cwl_input'], should we add some test to exercise the cwl_output part of this?
• What's the utility of recording this? I mean, will this data be consumed only by machines or should we document the feature for humans to know about it?

The rest LGTM

Lucas Di Pentima wrote in #note-10:

Just a couple of questions:

• All test fixes are related to properties['cwl_input'], should we add some test to exercise the cwl_output part of this?

I added a check for cwl_output to one test, thanks.

• What's the utility of recording this? I mean, will this data be consumed only by machines or should we document the feature for humans to know about it?

We didn't have a page that documents the properties used by the system, so I wrote one and added it to the API section.

In the process I also found that to avoid breaking "strict" vocabulary enforcement, I probably need to add these to the list of system properties in the vocabulary checker, so I did.

The rest LGTM

If you're happy with the documentation page let me know & I'll merge.

19466-cwl-io @ c634fdaf04b09ccd64d418c37dddc1eb7ff1c490

developer-run-tests: #3333

Just one small suggestion:

• I think it would be nice to link the "see below" comment on collection type properties, to future proof navigation in case this page eventually gets too long.

The rest LGTM, thanks!