Bug #19684
closed
Crash on workflow containing secrets
100%
Description
This hard crashes:
https://workbench2.tordo.arvadosapi.com/processes/tordo-xvhdp-z0lth3b4b6yv0hp
What is happening there is that the value that actually shows up in inputs.json is actually a level of indirection, it's a {$include: file} instead of the proper value.
I don't need it to resolve $include, but I do need it to not crash.
A layer of "do some sensible error handling when expected CWL input parameter type and the actual type in input.json don't match expectations" would be fine. It can just say "I can't show this value".
Files
Updated by Stephen Smith about 2 years ago
Changes at arvados-workbench2|fe41be6c6bcc21fc0c7c6450485a1d1f7955ebe5
Tests developer-tests-workbench2: #996
- Catches objects in primitive types and shows "Cannot display value"
- For File/Directory, I check for $include / $import keys on the object and display the message if found
Updated by Peter Amstutz about 2 years ago
Stephen Smith wrote in #note-3:
Changes at arvados-workbench2|fe41be6c6bcc21fc0c7c6450485a1d1f7955ebe5
Tests developer-tests-workbench2: #996
- Catches objects in primitive types and shows "Cannot display value"
- For File/Directory, I check for $include / $import keys on the object and display the message if found
This LGTM, thanks!
Updated by Stephen Smith about 2 years ago
- Status changed from New to Resolved