Bug #19840
closed
Gets confused by port numbers in docker image name
Added by Peter Amstutz about 2 years ago.
Updated about 2 years ago.
Estimated time:
(Total: 0.00 h)
Release relationship:
Auto
Description
Customer is using a docker reference that looks like this:
docker.cloud.example.com:443/rrtest:samtools_jp_v1.6.1
arv-keepdocker
splits on the first instance of ':' so the port number is messing it up -- it thinks "docker.cloud.example.com" is the name and "443/rrtest" is the tag (and the last part gets thrown away).
This case needs to be handled properly.
- Subject changed from Gets confused by port numbers in docker id to Gets confused by port numbers in docker image name
- Description updated (diff)
- Category set to Docker
- Description updated (diff)
- Description updated (diff)
- Description updated (diff)
- Assigned To set to Tom Clegg
- Status changed from New to In Progress
- Related to Feature #8333: [SDKs] `arv keep docker` supports `repo:tag` image name scheme added
This bug was mostly fixed in
#8333, but
- when listing/searching images already stored in Keep,
host:port/repo:tag
was still being split as ("host", "port/repo:tag")
, so the list output was wrong and upload would always re-upload even if the same image had already been uploaded.
- when the explicit port happens to be
443
, docker strips it off because it's redundant in an https url -- so after docker pull h:443/r:t
succeeds, docker inspect h/r:t
succeeds but docker inspect h:443/r:t
fails. Since arv-keepdocker
was doing the latter, it would always fail to save the image after pulling.
Fixed both issues and added tests.
19840-docker-port-number @ ed948e5ff97e22594d54845097dbea77048aa2fc -- developer-run-tests: #3409
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Also available in: Atom
PDF
Merge branch '19840-docker-port-number'
fixes #19840
Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curii.com>