Project

General

Profile

Actions
Copy link

Bug #20969

closed

Installer doesn't seem to restart nginx when a new bring-your-own cert is deployed

Added by Lucas Di Pentima over 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
Deployment
Target version:
Development 2023-10-25 sprint
Story points:
2.0
Release:
Arvados 3.0
Release relationship:
Auto

Subtasks 1 (0 open — 1 closed)

Task #21075: Review 20969-installer-nginx-reload-fixResolvedPeter Amstutz10/13/2023Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 2 years ago

  • Target version changed from Development 2023-09-27 sprint to Development 2023-10-11 sprint
Actions
Copy link
 #2

Updated by Peter Amstutz over 2 years ago

  • Story points set to 2.0
Actions
Copy link
 #3

Updated by Peter Amstutz over 2 years ago

  • Target version changed from Development 2023-10-11 sprint to Development 2023-10-25 sprint
Actions
Copy link
 #4

Updated by Peter Amstutz over 2 years ago

  • Target version changed from Development 2023-10-25 sprint to Development 2023-11-08 sprint
Actions
Copy link
 #5

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #6

Updated by Lucas Di Pentima over 2 years ago

Updates at 1d068f13d0 - branch 20969-installer-nginx-reload-fix
Debian11 provision test: test-provision-debian11: #523

Refactors the custom_certs state so that it reloads nginx only when both *.key & *.pem files are updated and correspond to each other. An initial attempt to just have a cmd.run state monitoring both files failed because it was executed on each file change, failing to reload the service on the first file copy.

Manually tested changing certs and confirming that the new ones were being used after running installer.sh deploy.

Actions
Copy link
 #7

Updated by Peter Amstutz over 2 years ago

  • Target version changed from Development 2023-11-08 sprint to Development 2023-10-25 sprint
Actions
Copy link
 #8

Updated by Peter Amstutz over 2 years ago

Lucas Di Pentima wrote in #note-6:

Updates at 1d068f13d0 - branch 20969-installer-nginx-reload-fix
Debian11 provision test: test-provision-debian11: #523

Refactors the custom_certs state so that it reloads nginx only when both *.key & *.pem files are updated and correspond to each other. An initial attempt to just have a cmd.run state monitoring both files failed because it was executed on each file change, failing to reload the service on the first file copy.

Manually tested changing certs and confirming that the new ones were being used after running installer.sh deploy.

This LGTM, thanks!

Actions
Copy link
 #9

Updated by Lucas Di Pentima over 2 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #10

Updated by Peter Amstutz almost 2 years ago

  • Release set to 70
Actions
Copy link

Also available in: Atom PDF