Project

General

Profile

Actions

Idea #21328

closed

Package build Dockerfiles clone from workspace, not git.arvados.org

Added by Brett Smith about 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assigned To:
-
Category:
Deployment
Target version:
-
Start date:
Due date:
Story points:
-

Description

As of January 2024, the package build Dockerfiles get a clean source checkout by cloning from git.arvados.org. This means you can't test local build changes before pushing them. It would both be more flexible, and more efficient, to mount the user's WORKSPACE as a volume, and git clone that instead.

Actions #1

Updated by Brett Smith 8 months ago

  • Status changed from New to Closed

build-docker-image.yml no longer does the steps that require a source checkout, and therefore mooted this issue.

The steps in question started in 25cf4518ef59c42652f4692ccc4e4208cf42155a and were meant to speed up repeated Go builds on the same image. That's a nice feature, but it comes up relatively rarely: our package build jobs always build everything from scratch. If someone wants to reimplement it in Ansible, we should do so by mounting $WORKSPACE into the Docker container during the build.

Actions #2

Updated by Brett Smith 8 months ago

  • Target version deleted (Future)
Actions

Also available in: Atom PDF