Arvados

arvados-client mount --log-level=debug ...

There's an existing arv-mount option called --logfile. It would be nice to accept --loglevel for symmetry. (If we also accept --log-level, fine.)

There is an existing --debug option that should be a shortcut for --loglevel=debug.

fwiw, costanalyzer, deduplicationreport, diagnostics, and recovercollection already accept "-log-level", and afaict we don't have anything that accepts "-loglevel".

21578-mount-debug @ b290de5604e7ccfad230cd1e0547f0c09cc2fe01 -- developer-run-tests: #4085

Example logs after doing some things like "ls asdfasdf", "mkdir asdfasdf":

DEBU[2024-03-15T11:26:00.742594509-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/by_id/asdfasdf
DEBU[2024-03-15T11:26:00.742743817-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/by_id/asdfasdf
DEBU[2024-03-15T11:26:07.672947349-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/by_id/asdfasdf
DEBU[2024-03-15T11:26:07.673209837-04:00] fuse call returned error                      errno=-38 error="invalid operation" op=Mkdir path=/by_id/asdfasdf
DEBU[2024-03-15T11:26:53.625915417-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/abcdefg
DEBU[2024-03-15T11:26:53.626102196-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/abcdefg
DEBU[2024-03-15T11:26:53.626174517-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/abcdefg
DEBU[2024-03-15T11:27:02.328901455-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/abcdefg
DEBU[2024-03-15T11:27:09.657885275-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/abcdefg
DEBU[2024-03-15T11:27:09.658023614-04:00] fuse call returned error                      errno=-38 error="invalid operation" op=Mkdir path=/abcdefg
DEBU[2024-03-15T11:27:52.142643769-04:00] fuse call returned error                      errno=-2 error="file does not exist" op=Getattr path=/by_id/jutro-4zz18-nm6dir7pkhhbrf3/abcdefg

Tom Clegg wrote in #note-5:

fwiw, costanalyzer, deduplicationreport, diagnostics, and recovercollection already accept "-log-level", and afaict we don't have anything that accepts "-loglevel".

My personal philosophy about this is, it's ideal for everything to be consistent, but local consistency trumps wider consistency. Consistency within one tool's options is more important than consistency across tools. So if the goal is to eventually make this a drop-in replacement for arv-mount, and it's going eventually grow a --logfile option, then the --loglevel option would be best for local consistency.

But that's just, like, my opinion, man.

I suppose we can get both kinds of consistency by having arvados-client mount accept -log-level, and (eventually? or should we do this now?) -log-file for symmetry and -logfile for compatibility with arv-mount.

Tom Clegg wrote in #note-8:

I suppose we can get both kinds of consistency by having arvados-client mount accept -log-level, and (eventually? or should we do this now?) -log-file for symmetry and -logfile for compatibility with arv-mount.

Yes, that would work fine. From a process perspective, I'm very worried we're going to repeat the history of Workbench 2, where we promise feature parity, and then later problems with arv-mount cause us to promote arvados-client mount before we implement feature parity, and then we just give up. To prevent history from repeating, I think it would be good if we implemented interface parity at the same time that we implement functionality parity, rather than planning to develop it separately later. But, obviously I'm not "supposed" to worry about this, it's not my call to make, it's Peter's.

Right. I was assuming we would want to implement interface parity (-logfile == -log-file) at the same time as functionality parity. I was just trying to ask whether that time is now, or later.

Arguably -logfile functionality is not just about sending logs to a file instead of stderr, but also about writing crunchstat-style metrics as logs, which I definitely don't want to scope-creep into this ticket.

21578-mount-debug @ cb68d4e34688abd308d7adffc288c82a5deb6c85 -- developer-run-tests: #4091

adds -debug alias for -log-level=debug, and merges main to fix tests.

Tom Clegg wrote in #note-11:

21578-mount-debug @ cb68d4e34688abd308d7adffc288c82a5deb6c85 -- developer-run-tests: #4091

LGTM, thanks.