Project

General

Profile

Actions

Bug #22431

closed

"tunnel connection started" spam

Added by Peter Amstutz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Story points:
-
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #22452: Review 22431-tunnel-log-spamResolvedTom Clegg01/14/2025Actions
Actions #1

Updated by Peter Amstutz about 1 year ago

  • Position changed from -933175 to -933172
Actions #2

Updated by Peter Amstutz about 1 year ago

  • Assigned To set to Tom Clegg
Actions #3

Updated by Peter Amstutz about 1 year ago

  • Subtask #22452 added
Actions #4

Updated by Tom Clegg about 1 year ago

  • Status changed from New to In Progress
Actions #5

Updated by Brett Smith about 1 year ago

Sure. Out of curiosity, what about the log in maintainTunnel? Would that get spammy if someone was actually connected to the tunnel? I'm a little surprised it seems to log unconditionally, whether or not err != nil.

Actions #6

Updated by Tom Clegg about 1 year ago

runTunnel is meant to run "forever" (until the process exits) -- if it returns at all, that means the controller end hung up, there's a network issue, or something else abnormal/unexpected, so I think it makes sense to keep logging that. I've added comments to make the code look less fishy.

22431-tunnel-log-spam @ 1d42d4b1454516431db869a87fce334dd1b6d137

Actions #7

Updated by Brett Smith about 1 year ago

Tom Clegg wrote in #note-6:

runTunnel is meant to run "forever" (until the process exits) -- if it returns at all, that means the controller end hung up, there's a network issue, or something else abnormal/unexpected, so I think it makes sense to keep logging that. I've added comments to make the code look less fishy.

That makes sense and these are helpful comments, thanks. Please merge.

Actions #8

Updated by Tom Clegg about 1 year ago

  • Status changed from In Progress to Resolved
Actions #9

Updated by Peter Amstutz about 1 year ago

  • Release set to 75
Actions

Also available in: Atom PDF