Bug #22431
closed"tunnel connection started" spam
Updated by Peter Amstutz about 1 year ago
- Position changed from -933175 to -933172
Updated by Tom Clegg about 1 year ago
- Status changed from New to In Progress
22431-tunnel-log-spam @ 4c6b4eeb5663c31bc6ca75a753da2a719e3117b6 -- developer-run-tests: #4598
Updated by Brett Smith about 1 year ago
Sure. Out of curiosity, what about the log in maintainTunnel? Would that get spammy if someone was actually connected to the tunnel? I'm a little surprised it seems to log unconditionally, whether or not err != nil.
Updated by Tom Clegg about 1 year ago
runTunnel is meant to run "forever" (until the process exits) -- if it returns at all, that means the controller end hung up, there's a network issue, or something else abnormal/unexpected, so I think it makes sense to keep logging that. I've added comments to make the code look less fishy.
22431-tunnel-log-spam @ 1d42d4b1454516431db869a87fce334dd1b6d137
Updated by Brett Smith about 1 year ago
Tom Clegg wrote in #note-6:
runTunnel is meant to run "forever" (until the process exits) -- if it returns at all, that means the controller end hung up, there's a network issue, or something else abnormal/unexpected, so I think it makes sense to keep logging that. I've added comments to make the code look less fishy.
That makes sense and these are helpful comments, thanks. Please merge.
Updated by Tom Clegg about 1 year ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|730c5f6c5d8e12d4d89d85a401d5dbdecf90c93e.