Project

General

Profile

Actions

Bug #22564

closed

More testing for multiselect

Added by Peter Amstutz about 1 year ago. Updated 10 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Description

Some tests we should include:
  • Deleting multiple resources
  • Deleting mixed resource types (collections and projects together)
  • Untrashing multiple resources and mixed resource types

Among other multi select tests


Subtasks 1 (0 open1 closed)

Task #22640: Review 22564-multiselect-testsResolvedStephen Smith04/24/2025Actions

Related issues 5 (0 open5 closed)

Related to Arvados - Bug #22197: Workbench crashes when a user selects more than one subprocess (just testing remaining)ResolvedLisa KnoxActions
Related to Arvados - Bug #22772: Selection under the "Workflow runs" tabResolvedLisa KnoxActions
Related to Arvados - Bug #22814: Group details panel toolbar uses wrong "remove user" actionResolvedLisa KnoxActions
Related to Arvados - Bug #22813: Group edit dialog is listed inconsistently; does not save propertiesResolvedStephen SmithActions
Related to Arvados - Bug #22787: Incorrect selection when closing details panelResolvedStephen SmithActions
Actions #1

Updated by Peter Amstutz about 1 year ago

  • Position changed from -939806 to -939794
  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz about 1 year ago

  • Category set to Workbench2
Actions #3

Updated by Peter Amstutz about 1 year ago

  • Related to Bug #22197: Workbench crashes when a user selects more than one subprocess (just testing remaining) added
Actions #4

Updated by Peter Amstutz about 1 year ago

  • Status changed from In Progress to New
Actions #5

Updated by Brett Smith about 1 year ago

  • Subtask #22640 added
Actions #6

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2025-03-19 to Development 2025-04-02
Actions #7

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2025-04-02 to Development 2025-04-16
Actions #8

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2025-04-16 to Development 2025-04-02
Actions #9

Updated by Peter Amstutz about 1 year ago

  • Target version changed from Development 2025-04-02 to Development 2025-04-16
Actions #10

Updated by Peter Amstutz 12 months ago

  • Target version changed from Development 2025-04-16 to Development 2025-04-30
Actions #11

Updated by Stephen Smith 12 months ago

  • Description updated (diff)
Actions #12

Updated by Stephen Smith 12 months ago

  • Description updated (diff)
Actions #13

Updated by Lisa Knox 12 months ago

  • Target version changed from Development 2025-04-30 to Development 2025-04-16
  • Assigned To set to Lisa Knox
  • Status changed from New to In Progress
Actions #14

Updated by Lisa Knox 12 months ago

To compile a list:

  • selecting/deselecting items should:
    • select/deselect the correct items
    • display the correct toolbar items
  • select all/deselect all/invert selection in popover should:
    • select/deselect the correct items
    • display the correct toolbar items
  • For each resource type:
    • the correct toolbar is displayed when:
      • One of that resource is selected
      • Multiple of that resource are selected
      • Some of these tests already exist, project.cy.js L231 for example. These should be removed because it's better to have all of these tests in the same place.
    • Moving
      • single item
      • multiple of the same resource type
    • Trashing
      • single item
      • multiple of the same resource type
    • Untrashing
      • single item
      • multiple of the same resource type
  • For mixed resource selections:
    • for project & collections:
      • Trashing mixed selection
      • Untrashing mixed selection
      • Moving mixed selection
    • for processes & any other resource:
      • no multiselect options should exist
  • Subprocess panel should have all of the functionality of the main process view
Actions #15

Updated by Peter Amstutz 12 months ago

Selection under the "Workflow runs" tab is buggy:

  1. Load workbench and go to the "Workflow runs" tab where there are a bunch of workflows
  2. Click on the "Select all" check box
  3. Nothing happens

  1. Load workbench and go to the "Workflow runs" tab where there are a bunch of workflows
  2. Open the select menu and choose "All"
  3. Nothing happens

  1. Load workbench and go to the "Data" tab where there are projects/collections
  2. Click on the "Select all" check box
  3. Everything is selected as expected

  1. Load workbench and go to the "Workflow runs" tab where there are a bunch of workflows
  2. Click on the "Select all" check box
  3. Nothing happens
  4. go to the "Data" tab where there are projects/collections
  5. Click on the "Select all" check box
  6. Nothing happens

  1. Load workbench and go to the "Workflow runs" tab where there are a bunch of workflows
  2. Select the top 2 items by click on the boxes on the left
  3. Click on the "select all" box at the top
  4. It toggles the selection of those two items and nothing else

  1. Load workbench and go to the "Workflow runs" tab where there are a bunch of workflows
  2. Select the top 2 items by click on the boxes on the left
  3. Select "invert" from the selection menu
  4. The two items are de-selected but nothing else is selected
Actions #16

Updated by Peter Amstutz 12 months ago

So the testing is really that

a) multiple selection, de-select, and select all/none/invert all behave as intended for the various instances of the data tables
b) selection continues to be correct and behave correctly after move/trash/delete operations have caused the table contents to change.

Actions #17

Updated by Lisa Knox 12 months ago

  • Related to Bug #22772: Selection under the "Workflow runs" tab added
Actions #18

Updated by Lisa Knox 12 months ago

For clarity, this ticket is for writing the tests, and the "workflow runs" selection bug is covered in #22772

Actions #19

Updated by Peter Amstutz 11 months ago

  • Target version changed from Development 2025-04-16 to Development 2025-04-30
Actions #20

Updated by Lisa Knox 11 months ago

  • Related to Bug #22814: Group details panel toolbar uses wrong "remove user" action added
Actions #21

Updated by Lisa Knox 11 months ago

  • Related to Bug #22813: Group edit dialog is listed inconsistently; does not save properties added
Actions #22

Updated by Lisa Knox 11 months ago

  • Related to Bug #22787: Incorrect selection when closing details panel added
Actions #23

Updated by Lisa Knox 11 months ago

22564-multiselect-tests @ 8030f9c0837a732de1585114f293c1cd989ee5c7
developer-run-tests-services-workbench2: #1507

  • ✅ All agreed upon points are implemented / addressed.
  • ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
    • no manual testing was done
  • n/a New or changed UX/UX and has gotten feedback from stakeholders.
  • n/a Documentation has been updated.
  • ✅ Behaves appropriately at the intended scale (describe intended scale).
  • ✅ Considered backwards and forwards compatibility issues between client and server.
    • no change
  • ✅ Follows our coding standards and GUI style guidelines.
Notes:
  • The doToolbarAction command doesn't always work, and I was unable to figure out why. The alternative is a single line of code that uses the same selector, so I used that where I had to.
  • There were several issues trying to test actions that copy to the clipboard. Fortunately, with the unification of the context and toolbar menu actions, these cases are covered in other tests, so I left them out where they were a problem.
Actions #24

Updated by Stephen Smith 11 months ago

Just one small comment, it looks like doGroupDetailsPanelSelect is only different from doDataExplorerSelect so that it can ignore the other checkbox in the group details rows, I think it would make sense to change the logic of doDataExplorerSelect to only get the first checkbox so that we can use the same helper for all cases - I think it's safe to assume the multi select checkbox will always be the first checkbox in the row:

.find('input[type=checkbox]')
.first()
.click()

(I think that should work)

Aside from that lgtm!

Actions #25

Updated by Lisa Knox 11 months ago

  • Status changed from In Progress to Resolved
Actions #26

Updated by Peter Amstutz 10 months ago

  • Release set to 78
Actions

Also available in: Atom PDF