Bug #22666
closed
Add tests that keepstore.BlockRead properly handles CheckCacheOnly option
Description
This behavior was added in #22320 as part of a larger branch, for API consistency. IMO we should have tests that this specific function handles the option properly. This is expected to be straightforward, it just didn't happen in the original branch because of scheduling issues around a release.
Updated by Brett Smith about 1 year ago
- Follows Feature #22320: Add Repack(opts RepackOptions) method to collectionfs, dirnode, and filehandle added
Updated by Peter Amstutz
Updated by Tom Clegg 12 months ago
- Status changed from New to In Progress
22666-test-checkcacheonly @ 25bbe5b3ed49a77110773f06abfabebe4a61d116 -- developer-run-tests: #4710
Updated by Brett Smith 12 months ago
Tom Clegg wrote in #note-4:
22666-test-checkcacheonly @ 25bbe5b3ed49a77110773f06abfabebe4a61d116 -- developer-run-tests: #4710
My one comment suggestion would be in the docstring, rather than saying "currently," spell that out as Arvados 3.1.0/March 2025, to clarify the context it's being written in. But either way this LGTM, thank you.
Updated by Tom Clegg 12 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|77db2887744c9c8631d7ceab372887fee41c157c.