Project

General

Profile

Actions

Bug #22784

closed

Workbench should not try to log empty dispatch status messages

Added by Brett Smith 11 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Description

When Workbench queries the status of a queued container request, if the dispatcher returns no information (e.g., because it's not the cloud dispatcher), Workbench should not try to render anything. As of 3.1.0 it logs the empty message with a timestamp which looks goofy and is unhelpful.

Workbench should not try to predict whether or not the dispatcher will return a status message. Hopefully more dispatchers will do so in the future. Continue querying dispatcher status as we do now. The only change is, if that dispatch message is empty, short circuit rendering it in the log console. Here in source:services/workbench2/store/process-logs-panel/process-logs-panel-actions.ts :

               if (process?.container?.state === ContainerState.QUEUED || process?.container?.state === ContainerState.LOCKED) {
                    const containerStatus: ContainerStatus = await containerRequestService.containerStatus(process?.containerRequest?.uuid, false);
                    logFragments.push({
                        logType: LogEventType.SCHEDULING,
                        contents: [`${new Date().toISOString()} ${containerStatus.schedulingStatus}`],
                    });
                }

We should check that containerStatus.schedulingStatus has a non-whitespace character in it before calling logFragments.push.


Subtasks 1 (0 open1 closed)

Task #23071: Review 22784-wb-filter-empty-dispatch-msgResolvedStephen Smith09/02/2025Actions
Actions #1

Updated by Peter Amstutz 10 months ago

  • Target version set to Development 2025-06-25
Actions #2

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2025-06-25 to Development 2025-07-09
Actions #3

Updated by Peter Amstutz 10 months ago

  • Category changed from Workbench to Workbench2
Actions #4

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2025-07-09 to Development 2025-07-23
Actions #5

Updated by Peter Amstutz 10 months ago

  • Target version changed from Development 2025-07-23 to Future
Actions #6

Updated by Brett Smith 9 months ago

  • Target version deleted (Future)
Actions #7

Updated by Brett Smith 8 months ago

  • Target version set to Development 2025-08-06
  • Assigned To set to Stephen Smith
  • Description updated (diff)
Actions #8

Updated by Brett Smith 8 months ago

  • Subtask #23071 added
Actions #9

Updated by Brett Smith 8 months ago

  • Description updated (diff)
Actions #10

Updated by Brett Smith 8 months ago

  • Description updated (diff)
Actions #11

Updated by Brett Smith 8 months ago

  • Target version changed from Development 2025-08-06 to Development 2025-08-21
Actions #12

Updated by Brett Smith 7 months ago

  • Target version changed from Development 2025-08-21 to Development 2025-09-03
Actions #13

Updated by Stephen Smith 7 months ago

  • Status changed from New to In Progress

Changes at arvados|2584224a9a74b9fa59b41fe053813c1714ead71a branch 22784-wb-filter-empty-dispatch-msg
Tests developer-run-tests-services-workbench2: #1600

  • All agreed upon points are implemented / addressed.
    • Added a simple filter to check if the schedulingStatus contains only whitespace to avoid adding empty dispatch status messages
    • Added tests to verify that whitespace characters do not trigger added log lines
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • none
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Yes
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • no change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • none
  • Follows our coding standards and GUI style guidelines.
    • Yes
Actions #14

Updated by Lisa Knox 7 months ago

LGTM

Actions #15

Updated by Stephen Smith 7 months ago

  • Status changed from In Progress to Resolved
Actions #16

Updated by Brett Smith 6 months ago

  • Release set to 79
Actions

Also available in: Atom PDF