Arvados

22785-ambiguous-column @ 5fafe99323b48aad6433ad0c6bc206d023726195 -- developer-run-tests: #4753

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • ✅ Fixes ambiguous column name in query
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • ✅ Added a test case that reproduces the bug. If you run tests at 4ac2ff3901 (with the test, but no fix), you get

    Failure:
    Arvados::V1::GroupsControllerTest#test_get_objects_with_ambiguous_column_name_in_order_param [/home/tom/arvados/services/api/test/functional/arvados/v1/groups_controller_test.rb:362]:
    Expected response to be a <2XX: success>, but was a <422: Unprocessable Content>
    Response body: {"errors":["#<ActiveRecord::StatementInvalid:\"PG::AmbiguousColumn: ERROR:  column reference \\\"created_at\\\" is ambiguous\\nLINE 1: ...ontainers.state in ('Queued','Locked'))) ORDER BY created_at...\\n                                                             ^\\n\"> ()"],"error_token":"1745608934+99d736e5"}
    

• New or changed UX/UX and has gotten feedback from stakeholders.
  • n/a
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • n/a
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • ✅

This also fixes a minor optimization bug. The last part of load_limit_offset_order_params deduplicates the order by entries and strips superfluous entries, e.g., given "uuid, created_at" it will use just "uuid", which is functionally identical and (at least at the time we wrote that) more efficient. This wasn't working for groups#contents queries: it assumed all orders entries were fully qualified with table names, but that wasn't the case when called with fill_table_names: false. I fixed this by moving the "optimize" code into a separate func and calling it separately from the contents controller.

This LGTM