Bug #22813
closed
Group edit dialog is listed inconsistently; does not save properties
Description
Original description¶
When using the "Rename" action from either the toolbar or the context menu on a user group, a dialog titled "Edit Group" appears with a name field, a description field that uses the Richtext editor and a selector for property tags. The description gets saved but the properties do not.
I suggest we either:- make the group rename dialog only rename groups
or - change the menu action to read "Edit group" instead of just "rename"
Either way, the property selector should be removed because they don't get saved to the DB anyway.
Things to fix¶
- The context menu action/action bar tooltip should say "Edit group" instead of "Rename"
- Group properties should be loaded and saved so that editing properties works correctly (currently you can enter properties but they don't seem to be saved at all)
Updated by Lisa Knox 11 months ago
- Related to Bug #22564: More testing for multiselect added
Updated by Peter Amstutz
Updated by Brett Smith 7 months ago
- Target version set to Development 2025-09-03
Updated by Brett Smith 7 months ago
- Release set to 83
- Target version deleted (
Development 2025-09-03)
Updated by Brett Smith 7 months ago
Lisa Knox wrote:
Fix the following:
- The context menu action/action bar tooltip should say "Edit group" instead of "Rename"
- Group properties should be loaded and saved so that editing properties works correctly (currently you can enter properties but they don't seem to be saved at all)
Confirmed all of this is still an issue as of v3.2.0~dev20250902174833.
Updated by Brett Smith 6 months ago
- Subject changed from Groups use incorrect "Rename" dialog to Group edit dialog is listed inconsistently; does not save properties
Updated by Brett Smith 6 months ago
- Related to Feature #23111: Add Overview tab to Group page added
Updated by Brett Smith 6 months ago
- Target version set to Development 2025-10-15
- Assigned To set to Stephen Smith
Updated by Stephen Smith 5 months ago
Changes at arvados|4bf58c3e5f4cae8a8ea2eeaf791a3c2e3c7e8bd5 branch 22813-group-edit-properties
Tests developer-run-tests-services-workbench2: #1652
- All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
- Added a new label for "Edit group"
- Opening the edit dialog now fetches the full group resource from the store
- Edit and create group now passes properties to their respective service calls
- Added tests for creating and updating groups with properties
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- none
- Code is tested and passing, both automated and manual, what manual testing was done is described.
- Added new tests
- The tested code incorporates recent main branch changes.
- yes ("Incorporates" = merged or rebased. "Recent" = 2-3 working days. The more active development on this component is, the more important it is to be based on recent main to avoid surprising test failures post-merge.)
- New or changed UI/UX has gotten feedback from stakeholders.
- n/a
- Documentation has been updated.
- n/a
- Behaves appropriately at the intended scale (describe intended scale).
- no change
- Considered backwards and forwards compatibility issues between client and server.
- none
- Follows our coding standards and GUI style guidelines.
- yes
Updated by Brett Smith 5 months ago
- Target version changed from Development 2025-10-15 to Development 2025-10-29
Updated by Lisa Knox 5 months ago
Everything here looks good, but I noticed that multiselect-toolbar.cy.js wasn't updated, which should have been necessary. When I looked, I saw that line 1218 contains describe.only(...) which is 100% on me. Please remove this and update the relevant parts of that file, then LGTM as long as tests pass.
Updated by Stephen Smith 5 months ago
- Status changed from In Progress to Resolved