Bug #22828
closed
`arvados-client diagnostics` does not respect empty Webshell ExternalURL:
Description
source:lib/config/config.default.yml documents Services.WebShell.ExternalURL with:
# ShellInABox service endpoint URL for a given VM. If empty, do not
# offer web shell logins.
But in source:lib/diagnostics/cmd.go, when we test WebShell at:
diag.dotest(150, "connecting to webshell service", func() error {
It does not check for the empty URL. Instead it generates a bad URL that leads to reporting an error:
ERROR 150: connecting to webshell service (0 ms): Post "z2a05s?": unsupported protocol scheme ""
Updated by Peter Amstutz
Updated by Tom Clegg 10 months ago
22828-empty-webshell-ok @ 6150501186354eea3b2037ca05ee30e0e76653cb -- developer-run-tests: #4794
22828-empty-webshell-ok @ 6150501186354eea3b2037ca05ee30e0e76653cb -- developer-run-tests: #4796
retry remainder run-tests-remainder: #5264
Example output (tested on tordo with WebShell section commented out):
INFO 130: getting list of virtual machines INFO 150: connecting to webshell service INFO ... skipping, webshell not configured
Updated by Brett Smith 10 months ago
Tom Clegg wrote in #note-4:
22828-empty-webshell-ok @ 6150501186354eea3b2037ca05ee30e0e76653cb -- developer-run-tests: #4796
LGTM, thanks.
Updated by Tom Clegg 10 months ago
- Status changed from New to Resolved
Applied in changeset arvados|8050b710aaa96971bd6c3de790fe8c1a2f9501e5.