Bug #22936
closed
Inconsistent display of "Project where workflow will run"
Description
Seen on pirca running 3.1.2~rc2. Steps to reproduce:
- New→Run a workflow
- Select a workflow
- Select a project from the popup
On the following page, "Project where the workflow will run" is not aligned with other items in its row (it's lower) or column (it's further left).
Files
Updated by Brett Smith 7 months ago
- Target version set to Development 2025-09-17
Updated by Brett Smith 6 months ago
- Target version deleted (
Development 2025-09-17)
Updated by Brett Smith 6 months ago
- Target version set to Development 2025-10-01
Updated by Brett Smith 6 months ago
- Target version changed from Development 2025-10-01 to Development 2025-10-15
Updated by Stephen Smith 6 months ago
Changes at arvados|23719ea05c6fcc9010d4d5c0ad4692637f1a6fc9 branch 22936-run-workflow-styling
Tests developer-run-tests-services-workbench2: #1625
- All agreed upon points are implemented / addressed.
- Applied the same margins and spacing to the first row of the run process form as the rest
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- n/a
- Code is tested and passing, both automated and manual, what manual testing was done is described
- yes
- Documentation has been updated.
- n/a
- Behaves appropriately at the intended scale (describe intended scale).
- no change
- Considered backwards and forwards compatibility issues between client and server.
- none
- Follows our coding standards and GUI style guidelines.
- yes
Updated by Lisa Knox 6 months ago
- File misalignedinputs.png misalignedinputs.png added
- The input lines are misaligned:
- The font for the label 'Project where the workflow will run *' is noticeably larger than the font for 'Name for this workflow run *'. I know this is because they have different behaviors (one is a text input, the other opens a select modal) but they are right beside each other and they are identical except for the text size. This isn't strictly related to the original bug, but if it's a simple fix, it should probably get done while we're here.
Updated by Stephen Smith 6 months ago
Changes at arvados|2da6c792115bcdb63552a0e196529c6f76b294b0
Tests developer-run-tests-services-workbench2: #1638
- Replaced
FormGroup&FormLabelwithFormControl&InputLabelin GenericInput to match the input labels of MaterialTextField, along with usingshrinkand the standard variant - Added no-op onMouseDown handlers to some of the inputs because otherwise clicking on them permanently locks them into the focused state. Those inputs already have an onClick handler to open the dialog, and since those inputs effectively just use the input element as a fancy button to open the actual input dialog, it doesn't matter if users can't interact with the input elements beyond triggering the dialog.
- I also noticed that other non-text-input styled inputs like any array input that uses chips has a different height, but that doesn't seem as bad as 2 text inputs next to each other having a different height so I'm gonna say that's for another ticket.
Updated by Lisa Knox 5 months ago
- File revsorttoggle.png revsorttoggle.png added
This all looks great, but I found a side-effect:
I messed around and found that applying
sx={{
'& .MuiSwitch-thumb': {
marginTop: '8px',
},
'& .MuiSwitch-track': {
marginTop: '8px',
},
}}
to the <Switch /> in run-process-panel/inputs/boolean-input.tsx looks ok if you want to just handle it that way.
Updated by Stephen Smith 5 months ago
Updated by Stephen Smith 5 months ago
arvados|7c4ec73d9ad40b0cd49015ad097a61f137e86977
Tests developer-run-tests-services-workbench2: #1648
I added some margin to the wrapper element:
Updated by Stephen Smith 5 months ago
Updated by Stephen Smith 5 months ago
- Status changed from In Progress to Resolved