Arvados

source:lib/dispatchcloud/worker/pool.go

func (wp *Pool) sync(threshold time.Time, instances []cloud.Instance) {
        //...
                itTag := inst.Tags()[wp.tagKeyPrefix+tagKeyInstanceType]
                it, ok := wp.instanceTypes[itTag]
                if !ok {
                        wp.logger.WithField("Instance", inst.ID()).Errorf("unknown InstanceType tag %q --- ignoring", itTag)
                        continue
                }

22971-drain-unknown-instance-type @ 0a53ff54e368c4fddcb00b139fdfb6891d099982 -- developer-run-tests: #5003

Tom Clegg wrote in #note-4:

22971-drain-unknown-instance-type @ 0a53ff54e368c4fddcb00b139fdfb6891d099982 -- developer-run-tests: #5003

I would just like to wordsmith the logs a little. I have two concerns:

1. The next time we see this issue months from now, and we're just reading the logs, I don't think it will be clear that "invalid" means "not in cluster configuration."
2. I feel less strongly about this but I think it would be nice to write the action first then explain why it was taken.

Taken together, something like: "< draining | holding > instance with unconfigured type and IdleBehavior = %s" Happy to workshop it in chat if you want. This can be merged once we're on the same page.