Actions
Bug #23039
closedContainer logs toolbar disappears after you disable word wrapping
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
Seen on Workbench v3.2.0~dev20250703175452. Steps to reproduce:
- Open a container.
- Open the Logs tab.
- Press the "Disable word wrapping" button above the logs.
That entire toolbar disappears. It shouldn't. "Disable word wrapping" should be replaced with an "Enable word wrapping" button.
Updated by Lisa Knox 7 months ago
23039-logs-toolbar @ 039f9853f3409f2e7b28b563edd3cb5212f3c638
developer-run-tests-services-workbench2: #1578
- ✅ All agreed upon points are implemented / addressed.
- The toolbar didn't actually disappear: When word wrap is disabled, the logs will take up all the width they need, making the parent element expand as well. The position of the toolbar was governed by the parent element, so the toolbar was still there, you just had to scroll all the way right to see it.
- Refactored the logs panel layout so that the logs can expand horizontally without affecting the toolbar.
- n/a Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- ✅ The tested code incorporates recent main branch changes.
- n/a New or changed UX/UX and has gotten feedback from stakeholders.
- n/a Documentation has been updated.
- ✅ Behaves appropriately at the intended scale (describe intended scale).
- n/a Considered backwards and forwards compatibility issues between client and server.
- ✅ Follows our coding standards and GUI style guidelines.
Updated by Stephen Smith 7 months ago
One minor nit: The indentation in ProcessLogsCard for the changes seems a little messed up
Besides that, lgtm!
Updated by Lisa Knox 7 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|875c07612c7eba1962745dc28d230a3b9a0038f3.
Actions