Bug #23063
closed
Process overview should filter out cwl_input and cwl_output properties
Description
As part of #22793 we started showing process properties on the overview tab. Hooray!
However, it is currently (trying to) show the cwl_input and cwl_output properties. These are specially reserved properties that we already use to render the Inputs and Outputs tabs, respectively. It's redundant and a little confusing to show these both ways.
Because these cannot be rendered in chits, and because we already have tabs dedicated to rendering them, filter them out from the properties chits. We should still render other properties.
I think it is okay to filter these out of property chits everywhere if that simplifies the implementation. We specifically document that these are reserved for container requests, so we're not obligated to worry about user-defined properties with these names.
Updated by Brett Smith 8 months ago
- Related to Bug #23061: Improve Workbench display of compound property values added
Updated by Brett Smith 8 months ago
- Related to Idea #22793: Design sketch to unify Projects/Collections/Processes/Workflow with tab-based design added
Updated by Brett Smith 8 months ago
- Target version set to Development 2025-08-06
- Assigned To set to Lisa Knox
Updated by Lisa Knox 8 months ago
23063-process-properties @ 888353bd3759376250529aeb886c4a172c7017cb
developer-run-tests-services-workbench2: #1555
- ✅ All agreed upon points are implemented / addressed.
- ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- ✅ The tested code incorporates recent main branch changes.
- n/a New or changed UX/UX and has gotten feedback from stakeholders.
- n/a Documentation has been updated.
- ✅ Behaves appropriately at the intended scale (describe intended scale).
- ✅ Considered backwards and forwards compatibility issues between client and server.
- no changes
- ✅ Follows our coding standards and GUI style guidelines.
Updated by Stephen Smith 8 months ago
I have 1 suggestion - I noticed that the properties are filtered of object separately in process-details-attributes.tsx which achieves the same effect for the details panel. I think it would make sense to make a helper to do it in both places the same way unless there's a reason to display other objects in the overview panel but not in the details side panel.
Updated by Brett Smith 8 months ago
- Target version changed from Development 2025-08-06 to Development 2025-08-21
Updated by Lisa Knox 8 months ago
developer-run-tests-services-workbench2: #1561
23063-process-properties @ 6972c5531a89f1a83bec98c2b36ef5c5ae105fd1
I implemented your suggestion and added a test for the new implementation. Properties for all resources that are not Workflows are now handled by it, and Workflows are excluded because of the extra fetching and filtering they need.
Updated by Lisa Knox 8 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|102ccc01adb0a317782c12dd658280d4fdb9dc6f.