Project

General

Profile

Actions

Feature #23161

closed

Cancelling a process should require confirmation

Added by Brett Smith 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Description

When a user clicks the Cancel button for a running process, this should pop up our standard confirmation dialog and ask the user to confirm they want to do this destructive operation.


Subtasks 1 (0 open1 closed)

Task #23166: Review 23161-confirm-cancel-processResolvedStephen Smith10/05/2025Actions

Related issues 1 (0 open1 closed)

Related to Arvados - Feature #23026: UI to connect to a container's services from its pageResolvedStephen SmithActions
Actions #1

Updated by Stephen Smith 6 months ago

  • Related to Feature #23026: UI to connect to a container's services from its page added
Actions #2

Updated by Brett Smith 6 months ago

  • Target version set to Development 2025-10-01
Actions #3

Updated by Stephen Smith 6 months ago

  • Assigned To set to Stephen Smith
Actions #4

Updated by Brett Smith 6 months ago

We want this to work the same as every other confirmation dialog. Assuming it does, I see no need for interface review, except maybe double-checking the actual text of the dialog. If something happens that means we can't follow that plan, let me know.

Actions #5

Updated by Brett Smith 6 months ago

  • Subtask #23166 added
Actions #6

Updated by Stephen Smith 6 months ago

  • Status changed from New to In Progress
Actions #7

Updated by Brett Smith 6 months ago

  • Target version changed from Development 2025-10-01 to Development 2025-10-15
Actions #8

Updated by Stephen Smith 6 months ago

Changes at arvados|491b0ab06d03c763004029b13927f9d48e4d2f52 branch 23161-confirm-cancel-process
Tests developer-run-tests-services-workbench2: #1628

  • All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
    • Cleaned up mapDispatch methods that were unused
    • Added confirmation dialog to cancel process - also added to context menu since that shows up in the toolbar and could also be accidentally clicked about as easily as the cancel button itself
    • Changed wording to avoid having both dialog buttons be "Cancel"
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • none
  • Code is tested and passing, both automated and manual, what manual testing was done is described.
    • Adjusted to pass existing tests
  • The tested code incorporates recent main branch changes.
    • yes ("Incorporates" = merged or rebased. "Recent" = 2-3 working days. The more active development on this component is, the more important it is to be based on recent main to avoid surprising test failures post-merge.)
  • New or changed UI/UX has gotten feedback from stakeholders.
    • no significant change
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • no change
  • Considered backwards and forwards compatibility issues between client and server.
    • none
  • Follows our coding standards and GUI style guidelines.
    • yes
Actions #9

Updated by Lisa Knox 6 months ago

LGTM

Actions #10

Updated by Stephen Smith 6 months ago

  • Status changed from In Progress to Resolved
Actions #11

Updated by Brett Smith 6 months ago

  • Release changed from 83 to 79
Actions

Also available in: Atom PDF