Actions
Bug #23168
closedSalt installer custom TLS cert update procedure gets stuck and fails to restart nginx
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
We have observed that sometimes updating custom TLS certificates on nodes with many services makes salt to fail when restarting nginx.
Also, there's a check that runs the openssl tool to only restart nginx when the .crt and .key matches, and for some reason it's never returning so the entire deploy run gets stuck
Updated by Lucas Di Pentima 6 months ago
23168-salt-installer-tls-update @ 08a5e1268b72e
- All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
- Yes. Usage of
opensslwas rendered unnecessary by an improved way of reloadingnginxonly once after all cert/key pairs are updated.
- Yes. Usage of
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- No.
- Code is tested and passing, both automated and manual, what manual testing was done is described.
- Automated test are failing at the moment because of external reasons: The phusion passenger deb repo has some kind of problem and it's being worked on -- will retry as soon as it's reported to be fixed.
- This solution is already manually tested and implemented in running environments.
- The tested code incorporates recent main branch changes.
- Yes
- New or changed UI/UX has gotten feedback from stakeholders.
- No change on UI/UX
- Documentation has been updated.
- No
- Behaves appropriately at the intended scale (describe intended scale).
- Behaves a lot better (faster) on nodes that have many certs.
- Considered backwards and forwards compatibility issues between client and server.
- comments
- Follows our coding standards and GUI style guidelines.
- N/A
Updated by Brett Smith 6 months ago
Updated by Lucas Di Pentima 6 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|23e6b430c46bf9a82c70e5cd43e4b1b560121920.
Actions