Project

General

Profile

Actions

Bug #23168

closed

Salt installer custom TLS cert update procedure gets stuck and fails to restart nginx

Added by Lucas Di Pentima 6 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Story points:
-
Release relationship:
Auto

Description

We have observed that sometimes updating custom TLS certificates on nodes with many services makes salt to fail when restarting nginx.
Also, there's a check that runs the openssl tool to only restart nginx when the .crt and .key matches, and for some reason it's never returning so the entire deploy run gets stuck


Subtasks 1 (0 open1 closed)

Task #23169: Review 23168-salt-installer-tls-updateResolvedBrett Smith09/19/2025Actions
Actions #1

Updated by Lucas Di Pentima 6 months ago

23168-salt-installer-tls-update @ 08a5e1268b72e

test-provision: #1294

  • All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
    • Yes. Usage of openssl was rendered unnecessary by an improved way of reloading nginx only once after all cert/key pairs are updated.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • No.
  • Code is tested and passing, both automated and manual, what manual testing was done is described.
  • The tested code incorporates recent main branch changes.
    • Yes
  • New or changed UI/UX has gotten feedback from stakeholders.
    • No change on UI/UX
  • Documentation has been updated.
    • No
  • Behaves appropriately at the intended scale (describe intended scale).
    • Behaves a lot better (faster) on nodes that have many certs.
  • Considered backwards and forwards compatibility issues between client and server.
    • comments
  • Follows our coding standards and GUI style guidelines.
    • N/A
Actions #2

Updated by Lucas Di Pentima 6 months ago

  • Subtask #23169 added
Actions #3

Updated by Brett Smith 6 months ago

Lucas Di Pentima wrote in #note-1:

23168-salt-installer-tls-update @ 08a5e1268b72e

LGTM, thanks.

Actions #4

Updated by Lucas Di Pentima 6 months ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF