Arvados

23177-dashboard-root-proj-display @ 97871ead60b919bb76f4b706bd46caeaf6e5777c

developer-run-tests-services-workbench2: #1638

• ✅ All agreed upon points are implemented / addressed.
• n/a Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ The tested code incorporates recent main branch changes.
• n/a New or changed UX/UX and has gotten feedback from stakeholders.
• n/a Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
• no change
• ✅ Follows our coding standards and GUI style guidelines.

Imo adding on a name field to a user resource is a little weird since that is outside the bounds of the type, I think it would be better if we changed the getResource type param to NamedResource | UserResource for both ResourceName and ResourceNameNoLink and pass through the resource as-is with the type resource?: NamedResource | UserResource, then adjust renderName to accept item: NamedResource | UserResource and do an isUserResource check where it displays the name to switch between accessing .name and using the first/last name fields.

23177-dashboard-root-proj-display @ cc01e580bbe0883fd2f457dce95e75f0c8c8a43f

developer-run-tests-services-workbench2: #1646

done and done

LGTM assuming tests pass!

Merged main in to incorporate flaky test fix:

23177-dashboard-root-proj-display @ 9957c3b5de1b22c241556b8b1f3eb126ac0e9990

developer-run-tests-services-workbench2: #1649