Arvados

Changes at arvados|ef8feee09d8053d2ddf86108af733c6ef98aa55f branch 23179-renderer-types-rebase-1
Tests developer-run-tests-services-workbench2: #1632

Skipping the usual rubric since this is purely code cleanup with no functional changes

• Did some normalizing of type guards, it's convenient to have them all do an undefined check to keep other code terse, and where possible I use the Resource type as parameter.
• Created NamedResource interface to use where we expect a resource to have a name, freeing us from using the GroupContentsResource for renderer methods and maintaining type safety (as usual it's the implementer's responsibility to ensure the correct renderer is used in the correct place with named resources so that is unchanged)

These changes are some much-needed improvements to WB typing, thanks for doing this. Just one note:

• renderers.tsx L147: I'm never a fan of things like switch(true) because it doesn't actually do what a switch statement is meant to do. I think this block would be more concise and readable is we remove the switch and just use a series of if statements.

arvados|dbfb965e684d80088f2530f3d4bc4e93eb08686a
developer-run-tests-services-workbench2: #1633
Made that adjustment

Strictly speaking, since every if here ends in a return, none of the "else"s are necessary. Other than that, lgtm!