Arvados

23203-installer-alertmanager at 3d36110a

test-provision: #1329

Note each item completed with additional detail if necessary. If an item is irrelevant to a specific branch, briefly explain why.

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • Yes
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • No
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • Manually tested by deploying a multi-node cluster and configuring SMTP server to GMail's. Then used the test feature from Grafana's UI and confirmed I received the test email.
• The tested code incorporates recent main branch changes.
  • Yes
• New or changed UI/UX has gotten feedback from stakeholders.
  • No. New config knobs are optional.
• Documentation has been updated.
  • No
• Behaves appropriately at the intended scale (describe intended scale).
  • No change in scale
• Considered backwards and forwards compatibility issues between client and server.
  • This feature is optional and not setting the new config values keeps the feature off.
• Follows our coding standards and GUI style guidelines.
  • N/A

• As an additional change, I've fixed the node exporter dashboard to make it work with current Grafana versions.
• Added config values that allow an admin to configure Grafana's Alertmanager to send alerts through SMTP server, optionally with authentication.

Lucas Di Pentima wrote in #note-3:

23203-installer-alertmanager at 3d36110a

test-provision: #1329

LGTM, thanks.