Arvados

23211-credentials-search @ 246c5e87d14c2befb708372e31be8ccb9e725672 - developer-run-tests: #4924

Note this branch is based off the branch from #23210 to prevent a merge conflict. I have reviewed that branch and I'm happy with the implementation changes, including the changes to a-c-r that this touches. The changes you really need to review are all in b646d889128e47a9f6328c96a95c799c7c28a44c. The other commit is a trivial documentation typo fix.

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • Yes
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • N/A
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • Manually tested the different cases and confirmed they all basically work as expected. It would be nice to add automatic tests for this, but it would be a better use of time to do that as part of #23205.
• Tested code incorporates recent main branch changes.
  • See above about being based on #23210
• New or changed UI/UX and has gotten feedback from stakeholders.
  • Using s3://* to match any bucket was discussed and agreed post-standup.
• Documentation has been updated.
  • Yes
• Behaves appropriately at the intended scale (describe intended scale).
  • No change
• Considered backwards and forwards compatibility issues between client and server.
  • Because credentials have not been in any Arvados release yet, this change to semantics is okay (and this is the best time to do it)
• Follows our coding standards and GUI style guidelines.
  • Yes

LGTM! Just a note; I did a quick grep for the Python structural match syntax used in this changeset in the current Arvados codebase (the command was ag -G '.+\.py' '^\s*(match|case) .+:'). And this would be the first instance of the match/case syntax. Congrats! :)

Thanks for the quick review.

Zoë Ma wrote in #note-5:

And this would be the first instance of the match/case syntax. Congrats! :)

It only very recently became possible after we made Python 3.10 the minimum version in #23097.