Bug #23213: Update react-router to v5 - Arvados

Actions

Copy link

Bug #23213

closed

Update react-router to v5

Added by Stephen Smith 5 months ago. Updated 5 months ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Stephen Smith

Category:

Workbench2

Target version:

Development 2025-10-29

Story points:

Release:

Arvados 3.2.0

Release relationship:

Auto

Description

This ticket is to inch us closer to being up to date on react-router. Ideally we'd be >=7.5.2 but this at least gets us off of 1 abandoned dependency.

Update react-router, replace react-router-redux with connected-react-router to support react-router v5, and update react-redux to v6 to support connected-react-router, and update redux-form to support react-redux v6

Subtasks 1 (0 open — 1 closed)

Actions

Copy link

Updated by Stephen Smith 5 months ago

Changes at arvados|1f1755649bafe3e07850de929abc77098810367f branch 23213-react-router-upgrade
Tests developer-run-tests-services-workbench2: #1654

Bumped react-router to the latest v5
- Due to react-router-redux being deprecated and not supporting react-router v5, it's replaced with connected-react-router
  - connected-react-router requires bumping react-redux to v6
    - react-redux v6 requires bumping redux-form to v8
      - Due to redux-form being updated, I had to add memoization to dynamically generated anonymous validator functions, otherwise it seems redux-form will notice that the nextProps.validate is not equal (due to it having a different instance of the identical anonymous validator function), causing a re-render infinite loop.