Arvados

Changes at arvados|6575729f56ea76270823dc6f20ce3c171912d4d6 branch 23215-toolbar-alignment-2
Tests developer-run-tests-services-workbench2: #1668

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • After counting pixels I adjusted the top padding of the details card toolbar to 6px.
  • Since the toolbar is also used for runs/subprocesses, and DE title, I had to override the padding back to 0 - this seemed better than the other way since 3 cases are fewer than the number of details cards that would need to be overridden with 6px if I did it the other way, and I was able to remove a lot of repeated styles that were identical among all the details cards
  • When service container is running, the button row expands the title bar slightly, causing the main alignment issue - when making the service buttons I had already tried to squeeze it in to not expand the space but gave up, so in lieu of that I decided to just add a little bit of margin when the service buttons are visible
    • When the service buttons are shown, the available space is an odd number of pixels, so I went with the toolbar being 1px too high. The screenshots are hidpi with a pixel ratio of 3, so it looks like there's space to center it better, but it overshoots unless you start doing fractions of a pixel margin so I figured it was good enough.
  • For the screenshot, the text alignment is slightly different - every device I have produces slightly different text rendering (even with flatpak chrome), so I just used windows11 chrome and it looks alright - at least better than flatpak chrome which still doesn't vertically center some of the text well.
  • I also renamed the injectedStyles to toolbarClass, since thingClass is the typical pattern for passing a class name to a component.
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • none
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • yes, checked all uses of the toolbar for alignment changes to ensure only the details card alignment changed
• The tested code incorporates recent main branch changes.
  • yes
• New or changed UI/UX has gotten feedback from stakeholders.
  • n/a
• Documentation has been updated.
  • updated screenshots in docs
• Behaves appropriately at the intended scale (describe intended scale).
  • no change
• Considered backwards and forwards compatibility issues between client and server.
  • none
• Follows our coding standards and GUI style guidelines.
  • yes

The branch adds a file doc/sdk/R/index.html.md. I'm not sure what that's about but I don't think it should be there.

lgtm without the accidental doc file added