Actions
Bug #23322
closedUpgrade x/crypto per dependabot
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
SDKs
Target version:
Story points:
-
Release:
Release relationship:
Auto
Updated by Brett Smith 4 months ago
pr319-x-crypto @ 4032ceb71edb63f28086972121748581a68bc3af - developer-run-tests: #4952
- All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
- Yes
- The second commit (skipping our
httpErrorf) is to pass a new check ingo vetin 1.24. See the second paragraph.
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described.
- See above
- Tested code incorporates recent main branch changes.
- Yes
- New or changed UI/UX and has gotten feedback from stakeholders.
- N/A
- Documentation has been updated.
- N/A
- Behaves appropriately at the intended scale (describe intended scale).
- N/A
- Considered backwards and forwards compatibility issues between client and server.
- N/A
- Follows our coding standards and GUI style guidelines.
- N/A (no stylistic changes)
Updated by Tom Clegg 4 months ago
LGTM, thanks.
(It might be good to follow up by updating to toolchain go1.24.10 as well. There are various security fixes. https://go.dev/doc/devel/release#go1.24.minor)
Updated by Brett Smith 4 months ago
Tom Clegg wrote in #note-3:
(It might be good to follow up by updating to
toolchain go1.24.10as well. There are various security fixes. https://go.dev/doc/devel/release#go1.24.minor)
I have spun this off as #23325. Totally in favor, but as a scheduling matter, I'm working on #23310 and building a new Jenkins node is going to be part of that, so I'd like to time this upgrade around the same time.
Updated by Brett Smith 4 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|f630220467c81e8a3548b75f068f93a4b20f997c.
Actions