Project

General

Profile

Actions

Bug #23406

closed

Salt installer fails due to GPG error on phusion passenger package repo

Added by Lucas Di Pentima about 2 months ago. Updated 26 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Story points:
-
Release relationship:
Auto

Description

Here's an example of the failure: test-provision-salt: #23

The error is:

12:39:53 ----------
12:39:53           ID: nginx_install
12:39:53     Function: pkg.installed
12:39:53         Name: nginx
12:39:53       Result: False
12:39:53      Comment: An error was encountered while installing package(s): W: GPG error: https://oss-binaries.phusionpassenger.com/apt/passenger bookworm Release: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY D870AB033FB45BD1
12:39:53               E: The repository 'https://oss-binaries.phusionpassenger.com/apt/passenger bookworm Release' is not signed.
12:39:53      Started: 15:39:51.726289
12:39:53     Duration: 1997.58 ms
12:39:53      Changes:   
12:39:53 
12:39:53 Summary for local
12:39:53 -------------
12:39:53 Succeeded: 10 (changed=5)
12:39:53 Failed:     1
12:39:53 -------------

Last successful run was on Jan 22nd.


Subtasks 1 (0 open1 closed)

Task #23413: Review multiple branches (details in #note-6)ResolvedBrett Smith02/26/2026Actions
Actions #1

Updated by Brett Smith about 2 months ago

We don't even need this repository now that arvados-api-server builds its own Passenger. All this code can just be removed. I realize that might have some knock-off effects on the nginx install/configuration; I'm curious how much work it would be to adapt.

Actions #2

Updated by Lucas Di Pentima about 2 months ago

Brett Smith wrote in #note-1:

We don't even need this repository now that arvados-api-server builds its own Passenger. All this code can just be removed. I realize that might have some knock-off effects on the nginx install/configuration; I'm curious how much work it would be to adapt.

Right! and even if when we don't compile anymore (re: #22762), it will be downloaded directly. Hopefully there's a salt formula config knob that we can use to avoid setting this up.

Actions #3

Updated by Brett Smith about 2 months ago

  • Target version set to Development 2026-02-18
Actions #4

Updated by Brett Smith about 2 months ago

  • Subtask #23413 added
Actions #5

Updated by Brett Smith about 1 month ago

  • Target version changed from Development 2026-02-18 to Development 2026-03-04
Actions #6

Updated by Lucas Di Pentima 28 days ago ยท Edited

  • Branch:
    • 23406-salt-passenger-fix (arvados repo - 62879b89)
      • Removes nginx.passenger calls from multi-node and single-nodes cases.
      • Removes passenger-related nginx configurations
      • Renames nginx_passenger.sls pillars to just nginx.sls to avoid future confusion
    • 23406-pg-repo-fix (postgresql-formula repo) (https://github.com/arvados/postgres-formula/commit/cb05500e1dbea2c24cc29ea6831417f638853587)
      • Fixes an issue happening on the single-node case where PG is installed from the distro package repos. In debian12, there's an updated PG version 15.16 from bookworm-security and before the fix, PG 15.15 was being installed because the postgres-formula required the package being installed from the repo '<distroname>' (bookworm in this case). This made the install process fail because PG got upgraded in the same apt transaction as arvados-api-server gets installed, and because executing the DB migrations is part of the postinst stage and PG was not in a ready state by the time arvados-api-server needed it, the whole process failed.
    • 23406-nginx-requirement-fix (arvados-formula repo) (https://git.arvados.org/arvados-formula.git/commitdiff/b99b332f932fd75fe30e1a894c6f5ee674303593)
      • Makes sure arvados-controller service waits for nginx to get reloaded with the latest config
    • 23406-nginx-restart-fix (nginx-formula repo) (https://github.com/arvados/nginx-formula/commit/bca3cdbeda232c978a3e25c3ab8ca7bb6898845f)
      • Don't defer config changes to the end of a state run. This made arvados-controller readiness probe to fail because by the time it ran, nginx was reconfigured with the proper vhosts but not yet restarted.
  • Test run: test-provision-salt: #39
  • Also tested in multi-node successfully.
Actions #7

Updated by Brett Smith 26 days ago

LGTM, please merge, thanks.

Actions #8

Updated by Lucas Di Pentima 26 days ago

Brett Smith wrote in #note-7:

LGTM, please merge, thanks.

Thanks, will merge the formula branches first and update the commit pins on provision.sh before merging the main branch.

Actions #9

Updated by Lucas Di Pentima 26 days ago

Will merge once Jenkins finishes successfully.

Actions #10

Updated by Lucas Di Pentima 26 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF