Actions
Bug #23474
closedProcess logs panel toolbar overlaps details panel
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Description
The process logs toolbar overlaps the details panel when opened due to fixed positioning
Updated by Stephen Smith 12 days ago
ยท Edited
Changes at arvados|c32103f77c72c51f29c40d204c6b2664188e7b60 branch 23474-process-logs-toolbar-bug
Tests developer-run-tests-services-workbench2: #1692
- All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
- Removed right padding from card header to make space for toolbar in normal layout
- Changed toolbar class to toolbarWrapper and added toolbar class since I needed to add styles to the actual toolbar
- Removed fixed positioning, set flex to allow shrinking but not growing
- Added a small top/bottom negative margin to prevent expanding title bar height
- Set flex wrap to flex-end on toolbar buttons so it looks a little nicer when it wraps
- I don't think we really designed for small screens so it doesn't seem like there was any consideration for wrapping, this seems like the best and simplest behavior for the current design.
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- none
- Code is tested and passing, both automated and manual, what manual testing was done is described.
- Automated tests
- Checked that tooltip and select stay on top of the content (I didn't touch the z-index)
- The tested code incorporates recent main branch changes.
- recent
- New or changed UI/UX has gotten feedback from stakeholders.
- No significant changes
- Documentation has been updated.
- n/a
- Behaves appropriately at the intended scale (describe intended scale).
- no change
- Considered backwards and forwards compatibility issues between client and server.
- No issues
- Follows our coding standards and GUI style guidelines.
- Yes
Updated by Stephen Smith 11 days ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|74182e9b9da2c653b6b30c0347ed86d76a0321e3.
Actions